[Bug 226671] Merge Review: zlib

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: zlib


https://bugzilla.redhat.com/show_bug.cgi?id=226671





------- Additional Comments From varekova at redhat.com  2008-02-11 10:02 EST -------
>   zlib.x86_64: W: file-not-utf8 /usr/share/doc/zlib-1.2.3/ChangeLog
> The ChangeLog file could use a trip through iconv.

Thanks - fixed
> 
> The License: tag says BSD, but I would find it odd if the zlib package isn't
> under the zlib license.  I believe the License: tag should be "zlib".
I have discussed this issue with Tom Callaway and his recommendation was it is
"BSD" license so.

> I note that there's a small test suite; generally it's a good thing to call test
> suites even if they don't do all that much because they serve as a useful sanity
> check.  But I added a %check section and it seems that "make check" doesn't
> actually do anything for some reason.  When I call it manually I get some output
> ending with "*** zlib test OK ***".  I'm not really sure what the problem is.

check added.

I don't thing there is any reason to add minizip executables to subpackage so I
don't like to do it. If I overlook some good reason to do it, write it here
please. Thanks a lot.

The last version is zlib-1.2.3-17.fc9.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.