[Bug 427481] Review Request: publican - publication tool chain

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: publican - publication tool chain


https://bugzilla.redhat.com/show_bug.cgi?id=427481





------- Additional Comments From petersen at redhat.com  2008-02-11 23:35 EST -------
Thanks for the update.

> - Added gpl.txt

Thanks.  This is usually called "COPYING".
However the file you included is GPLv3.

> - Fix desktop file

Thanks.

> - Added Provides for documentation-devel

publican.src:20: W: unversioned-explicit-provides documentation-devel

I would suggest just to drop it unless there is a good
reason to keep it, in which case it should be versioned (see
Packaging/NamingGuidelines).

> - Put docs in sub package

Thanks!

> - Included GFDL txt file

fdl.txt is missing from the tarball.
Please also include it in the doc subpackage.

> - set full path to source

The url needs to go in the Source field.  The URL field is for the project URL.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.