[Bug 253741] Review Request: perl-VCS-LibCVS - Access CVS working directories and repositories

bugzilla at redhat.com bugzilla at redhat.com
Tue Feb 12 06:18:08 UTC 2008 

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-VCS-LibCVS - Access CVS working directories and repositories
Alias: perl-VCS-LibCVS

https://bugzilla.redhat.com/show_bug.cgi?id=253741


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2008-02-12 01:18 EST -------
Review:
+ package builds in mock (rawhide i386).
koji build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=417542
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
555b3f13d9c52f7202bafd18810e2dc8  VCS-LibCVS-1.0002.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test output is
t/lcvs-st....
Creating test repository, please be patient:................done
ok
All tests successful.
Files=1, Tests=111, 96 wallclock secs ( 4.47 cusr +  1.53 csys =  6.00 CPU)
+ Package perl-VCS-LibCVS-1.0002-2.fc9 ->
  Provides: perl(VCS::LibCVS) = 1.0002 perl(VCS::LibCVS::Admin)
perl(VCS::LibCVS::Branch) perl(VCS::LibCVS::Client)
perl(VCS::LibCVS::Client::Connection)
perl(VCS::LibCVS::Client::Connection::CvsPass)
perl(VCS::LibCVS::Client::Connection::Ext)
perl(VCS::LibCVS::Client::Connection::Local)
perl(VCS::LibCVS::Client::Connection::Pserver)
perl(VCS::LibCVS::Client::LoggingIOHandle) perl(VCS::LibCVS::Client::Request)
perl(VCS::LibCVS::Client::Request::Argument)
perl(VCS::LibCVS::Client::Request::ArgumentUsingRequest)
perl(VCS::LibCVS::Client::Request::ArgumentUsingRequests) = 1.0002-2.fc9
perl(VCS::LibCVS::Client::Request::Case)
perl(VCS::LibCVS::Client::Request::Checkin_time)
perl(VCS::LibCVS::Client::Request::Directory)
perl(VCS::LibCVS::Client::Request::Entry)
perl(VCS::LibCVS::Client::Request::Is_modified)
perl(VCS::LibCVS::Client::Request::Modified)
perl(VCS::LibCVS::Client::Request::Questionable)
perl(VCS::LibCVS::Client::Request::Requests) = 1.0002-2.fc9
perl(VCS::LibCVS::Client::Request::Root)
perl(VCS::LibCVS::Client::Request::Sticky)
perl(VCS::LibCVS::Client::Request::Unchanged)
perl(VCS::LibCVS::Client::Request::UseUnchanged)
perl(VCS::LibCVS::Client::Request::Valid_responses)
perl(VCS::LibCVS::Client::Request::add)
perl(VCS::LibCVS::Client::Request::annotate)
perl(VCS::LibCVS::Client::Request::ci) perl(VCS::LibCVS::Client::Request::co)
perl(VCS::LibCVS::Client::Request::diff)
perl(VCS::LibCVS::Client::Request::export)
perl(VCS::LibCVS::Client::Request::history)
perl(VCS::LibCVS::Client::Request::init) perl(VCS::LibCVS::Client::Request::log)
perl(VCS::LibCVS::Client::Request::noop)
perl(VCS::LibCVS::Client::Request::rdiff)
perl(VCS::LibCVS::Client::Request::remove)
perl(VCS::LibCVS::Client::Request::rlog)
perl(VCS::LibCVS::Client::Request::status)
perl(VCS::LibCVS::Client::Request::tag)
perl(VCS::LibCVS::Client::Request::update)
perl(VCS::LibCVS::Client::Request::valid_requests)
perl(VCS::LibCVS::Client::Request::version) perl(VCS::LibCVS::Client::Response)
perl(VCS::LibCVS::Client::Response::Checked_in)
perl(VCS::LibCVS::Client::Response::Clear_sticky)
perl(VCS::LibCVS::Client::Response::Copy_file)
perl(VCS::LibCVS::Client::Response::Created)
perl(VCS::LibCVS::Client::Response::E)
perl(VCS::LibCVS::Client::Response::FileUpdateModifyingResponse)
perl(VCS::LibCVS::Client::Response::FileUpdateModifyingResponses) = 1.0002-2.fc9
perl(VCS::LibCVS::Client::Response::FileUpdatingResponse)
perl(VCS::LibCVS::Client::Response::FileUpdatingResponses) = 1.0002-2.fc9
perl(VCS::LibCVS::Client::Response::M)
perl(VCS::LibCVS::Client::Response::Mbinary)
perl(VCS::LibCVS::Client::Response::Merged)
perl(VCS::LibCVS::Client::Response::Mod_time)
perl(VCS::LibCVS::Client::Response::Mode)
perl(VCS::LibCVS::Client::Response::New_entry)
perl(VCS::LibCVS::Client::Response::Patched)
perl(VCS::LibCVS::Client::Response::Remove_entry)
perl(VCS::LibCVS::Client::Response::Removed)
perl(VCS::LibCVS::Client::Response::Responses) = 1.0002-2.fc9
perl(VCS::LibCVS::Client::Response::Set_sticky)
perl(VCS::LibCVS::Client::Response::Update_existing)
perl(VCS::LibCVS::Client::Response::Updated)
perl(VCS::LibCVS::Client::Response::Valid_requests)
perl(VCS::LibCVS::Client::Response::error)
perl(VCS::LibCVS::Client::Response::ok) perl(VCS::LibCVS::Command)
perl(VCS::LibCVS::Datum) perl(VCS::LibCVS::Datum::DirectoryName)
perl(VCS::LibCVS::Datum::Entry) perl(VCS::LibCVS::Datum::FileContents)
perl(VCS::LibCVS::Datum::FileMode) perl(VCS::LibCVS::Datum::FileName)
perl(VCS::LibCVS::Datum::LogMessage) perl(VCS::LibCVS::Datum::PathName)
perl(VCS::LibCVS::Datum::RevisionNumber) perl(VCS::LibCVS::Datum::Root)
perl(VCS::LibCVS::Datum::String) perl(VCS::LibCVS::Datum::TagSpec)
perl(VCS::LibCVS::Datum::Time) perl(VCS::LibCVS::DirectoryBranch)
perl(VCS::LibCVS::FileBranch) perl(VCS::LibCVS::FileRevision)
perl(VCS::LibCVS::IgnoreChecker) perl(VCS::LibCVS::Repository)
perl(VCS::LibCVS::RepositoryDirectory) perl(VCS::LibCVS::RepositoryFile)
perl(VCS::LibCVS::RepositoryFileOrDirectory) perl(VCS::LibCVS::Slice)
perl(VCS::LibCVS::WorkingDirectory) perl(VCS::LibCVS::WorkingFile)
perl(VCS::LibCVS::WorkingFileOrDirectory) perl(VCS::LibCVS::WorkingUnmanagedFile)
Requires: /usr/bin/perl perl(Carp) perl(File::Spec) perl(File::Spec::Unix)
perl(FileHandle) perl(Getopt::Long) perl(IO::Dir) perl(IO::File)
perl(IO::Handle) perl(IO::Socket::INET) perl(IPC::Open2) perl(Time::Local)
perl(VCS::LibCVS) perl(VCS::LibCVS::Admin) perl(VCS::LibCVS::Branch)
perl(VCS::LibCVS::Client) perl(VCS::LibCVS::Client::Connection)
perl(VCS::LibCVS::Client::Connection::CvsPass)
perl(VCS::LibCVS::Client::Connection::Ext)
perl(VCS::LibCVS::Client::Connection::Local)
perl(VCS::LibCVS::Client::Connection::Pserver)
perl(VCS::LibCVS::Client::LoggingIOHandle) perl(VCS::LibCVS::Client::Request)
perl(VCS::LibCVS::Client::Request::Argument)
perl(VCS::LibCVS::Client::Request::ArgumentUsingRequests)
perl(VCS::LibCVS::Client::Request::Requests) perl(VCS::LibCVS::Client::Response)
perl(VCS::LibCVS::Client::Response::FileUpdateModifyingResponses)
perl(VCS::LibCVS::Client::Response::FileUpdatingResponses)
perl(VCS::LibCVS::Client::Response::Responses) perl(VCS::LibCVS::Command)
perl(VCS::LibCVS::Datum) perl(VCS::LibCVS::Datum::DirectoryName)
perl(VCS::LibCVS::Datum::Entry) perl(VCS::LibCVS::Datum::FileContents)
perl(VCS::LibCVS::Datum::FileMode) perl(VCS::LibCVS::Datum::FileName)
perl(VCS::LibCVS::Datum::LogMessage) perl(VCS::LibCVS::Datum::PathName)
perl(VCS::LibCVS::Datum::RevisionNumber) perl(VCS::LibCVS::Datum::Root)
perl(VCS::LibCVS::Datum::String) perl(VCS::LibCVS::Datum::TagSpec)
perl(VCS::LibCVS::Datum::Time) perl(VCS::LibCVS::DirectoryBranch)
perl(VCS::LibCVS::FileBranch) perl(VCS::LibCVS::FileRevision)
perl(VCS::LibCVS::IgnoreChecker) perl(VCS::LibCVS::Repository)
perl(VCS::LibCVS::RepositoryDirectory) perl(VCS::LibCVS::RepositoryFile)
perl(VCS::LibCVS::RepositoryFileOrDirectory) perl(VCS::LibCVS::Slice)
perl(VCS::LibCVS::WorkingDirectory) perl(VCS::LibCVS::WorkingFile)
perl(VCS::LibCVS::WorkingFileOrDirectory)
perl(VCS::LibCVS::WorkingUnmanagedFile) perl(constant) perl(strict) perl(vars)

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

More information about the Fedora-package-review mailing list