[Bug 427482] Review Request: publican-fedora - Fedora Publishing Theme

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: publican-fedora - Fedora Publishing Theme


https://bugzilla.redhat.com/show_bug.cgi?id=427482





------- Additional Comments From jfearn at redhat.com  2008-02-12 21:52 EST -------
(In reply to comment #10)
> rpmlint says:
> 
>  publican-fedora.src:16: W: unversioned-explicit-obsoletes
> documentation-devel-Fedora
> 
> This is ok, but probably it can be dropped assuming there aren't many people
> using the old package.
> 
>  publican-fedora.src: W: invalid-license Open Publication License
> 
> The Fedora short license name is "Open Publication": see
>
http://fedoraproject.org/wiki/Licensing#head-7c329132fff48be993272795da69b49c7812e8a9

Fixed.

> A few comments:
> 
> publican-0.29/Book_Template/en-US/ and publican-fedora-0.8/Book_Template/en-US
> are the same, but presumably they are duplicated because they are under
> different licenses, right?

This is correct.

> The README file says "for building Red_Hat_Enterprise_Linux documentation".

Changed to Fedora.
 
> It would be valuable to get comments on this package from the Fedora Docs project
> since I am not really qualified to evaluate the templates, etc.

It's pretty hard for the Fedora docs team to comment on this since they can't
actually use the system until it's in Fedora.

I'm sure once it is in there and they can play with it a bit, they will have a
bunch of changes to the look and feel, and the common content. In fact I'm
hoping they will want to take over this package :)

I don't think the content needs to be exact since no Fedora documentation uses
this system yet.

> Otherwise the package basically looks ok to me.

http://svn.fedorahosted.org/svn/publican/trunk/Files/publican-fedora-0.8-2.fc9.src.rpm
http://svn.fedorahosted.org/svn/publican/trunk/Files/publican-fedora.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.