[Bug 426867] Review Request: scala - Hybrid functional/object-oriented language

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: scala - Hybrid functional/object-oriented language


https://bugzilla.redhat.com/show_bug.cgi?id=426867





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-02-13 10:42 EST -------
For 2.6.1-8:

* Pre-rebuilt binaries
  - To make it sure that all files to be installed are
    built from free and legally compatible sources,
    remove _all_ pre-rebuilt binaries first at %prep like
-----------------------------------------------------------
%setup -q -a 2 -n %{name}-%{fullversion}
%patch0 -p1 
%patch1 -p1 
%patch2 -p1 
find . -name \*.jar -exec rm {} . \;
find . -name \*.dll -exec rm {} . \;
......
-----------------------------------------------------------

* Legal issue
  - Would you explain how the following files are used to
    build scala rpm?
-----------------------------------------------------------
src/library/scala/collection/immutable/Tree.scala in Source0
-----------------------------------------------------------

* Directory ownership issue
------------------------------------------------------------
/usr/share/vim/vimfiles/ftdetect/scala.vim   vim-scala-2.6.1-8.fc9  file
/usr/share/vim/vimfiles/ftdetect is not owned by any package
/usr/share/vim/vimfiles/indent/scala.vim     vim-scala-2.6.1-8.fc9  file
/usr/share/vim/vimfiles/indent is not owned by any package
/usr/share/vim/vimfiles/syntax/scala.vim     vim-scala-2.6.1-8.fc9  file
/usr/share/vim/vimfiles/syntax is not owned by any package
------------------------------------------------------------
  - IMO for now the 3 directories above should be owned by vim-scala
    (however you may file a bug against vim if you want).

* rpmlint
------------------------------------------------------------
ant-scala.noarch: W: no-documentation
ant-scala.noarch: W: conffile-without-noreplace-flag /etc/ant.d/scala
emacs-scala.noarch: E: percent-in-dependency emacs(bin) %{emacs_version}
emacs-scala-el.noarch: W: no-documentation
emacs-scala-el.noarch: E: percent-in-dependency emacs(bin) %{emacs_version}
scala-examples.noarch: W: no-documentation
------------------------------------------------------------
  Summary:
  * Please check where %emacs_version is defined
------------------------------------------------------------
[tasaka1 at localhost scala]$ rpm -q emacs-scala
emacs-scala-2.6.1-8.fc9.noarch
[tasaka1 at localhost scala]$ rpm -q --requires emacs-scala
emacs(bin) >= %{emacs_version}
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
------------------------------------------------------------

* Timestamps
  - Please recheck that "-p" option is correctly used when using "cp"
    or "install" commands to install files. For example,
-------------------------------------------------------------
for prog in scaladoc fsc scala scalac; do
        install -m 755 dists/scala-%{version}/bin/$prog $RPM_BUILD_ROOT%{_bindir}
        install -m 644 dists/scala-%{version}/man/man1/$prog.1
$RPM_BUILD_ROOT%{_mandir}/man1
done
-------------------------------------------------------------

* man file
  - Files under %_mandir are automatically marked as %doc.

* License document
  - For example, emacs-scala can be installed without scala itself.
    In this case, no license text of scala is installed, which is
    undesirable.
    i.e. All subpackages which don't require ant either directly or
         indirectly should also have license text as %doc.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.