[Bug 428718] Review Request: python-svn - Python bindings for Subversion

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-svn - Python bindings for Subversion


https://bugzilla.redhat.com/show_bug.cgi?id=428718


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-02-13 12:19 EST -------
For 1.5.2-5:

* rpm name
  - First of all, the name of rpm should be pysvn.

* pycxx dependency
  - This package uses pycxx 5.4.0
    http://cxx.sourceforge.net/
    Please file another review request for pycxx and make
    pysvn use system-wide pycxx.

* Parallel make
  - Support parallel make if possible.

* Timestamps
  - When using "install" or "cp" commands, please add "-p"
    option to keep timestamps on installed files.

* Documents
  - License text must be included as %doc if it exists.

* rpmlint
  - On i386:
------------------------------------------------------------------
python-svn.i386: W: unstripped-binary-or-object
/usr/lib/python2.5/site-packages/pysvn/_pysvn.so
python-svn-debuginfo.i386: E: empty-debuginfo-package
------------------------------------------------------------------
    This is because _pysvn.so does not have executional permission
    (the permission of _pysvn.so should be 0755)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.