[Bug 432655] Review Request: R-car - Companion to Applied Regression package for R
bugzilla at redhat.com
bugzilla at redhat.com
Wed Feb 13 21:21:49 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: R-car - Companion to Applied Regression package for R
https://bugzilla.redhat.com/show_bug.cgi?id=432655
------- Additional Comments From tibbs at math.uh.edu 2008-02-13 16:21 EST -------
Besides the standard R complaints, rpmlint says:
R-car.noarch: E: script-without-shebang /usr/share/R/library/car/CHANGES
R-car.noarch: E: wrong-script-end-of-line-encoding
/usr/share/R/library/car/CHANGES
The CHANGES file shouldn't be executable. However, once you fix that you'll get:
R-car.noarch: W: wrong-file-end-of-line-encoding
/usr/share/R/library/car/CHANGES
R-car.noarch: W: file-not-utf8 /usr/share/R/library/car/CHANGES
so it needs a chmod, a pass through tr and a pass through iconv.
I think that
http://cran.r-project.org/src/contrib/Descriptions/car.html
is probably better as a URL tag.
* source files match upstream:
e9bcb523b0d667e256aba10ab1c432e834f444d6e35cda0f4de446135013ce7d
car_1.2-7.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
X rpmlint has valid complaints.
* final provides and requires are sane:
R-car = 1.2-1.fc9
=
/bin/sh
R
* %check is present and all tests pass.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
X CHANGES file should not be executable.
* scriptlets are OK (R index installation)
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the Fedora-package-review
mailing list