[Bug 432791] Review Request: epdfview - Lightweight PDF document viewer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: epdfview - Lightweight PDF document viewer


https://bugzilla.redhat.com/show_bug.cgi?id=432791





------- Additional Comments From mschmidt at redhat.com  2008-02-15 07:21 EST -------
(In reply to comment #2)
> 1)tarball packages in SRPM does not preserve upstream released tarball
> timestamp. Good if you use wget and download tarball and package in SRPM.

OK, I redownloaded with wget and the tarball now has the original timestamp.

> 2)To preserve timestamps from files being copied from upstream tarball use
> make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"

Interesting, I've never seen this one mentioned in the guidelines. OK, done.

> 3) Drop following from SPEC
> Requires(post):         desktop-file-utils
> Requires(postun):       desktop-file-utils
> as per said at 
>
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-de6770dd9867fcd085a73a4700f6bcd0d10294ef

I see. I was confused by obsolete instructions in
http://fedoraproject.org/wiki/NewMIMESystem

I have copied the snippet from ScriptletSnippets and fixed the wiki page
NewMIMESystem too.

> 4)Use scriptlet of update-desktop-database as per given at
>
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-de6770dd9867fcd085a73a4700f6bcd0d10294ef

Done.

(In reply to comment #3)
> I can't see poppler-glib-devel on F8

True. poppler-glib-devel was split from poppler-devel in Rawhide.
I didn't originally plan to push the package to F8, but I have now made a
conditional special case in BuildRequires to make it build on F8 too.

Updated files:
http://michich.fedorapeople.org/epdfview/epdfview.spec
http://michich.fedorapeople.org/epdfview/epdfview-0.1.6-2.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.