[Bug 432817] Review Request: greyhounds - Greyhounds is a greyhounds racing and breeding game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: greyhounds - Greyhounds is a greyhounds racing and breeding game


https://bugzilla.redhat.com/show_bug.cgi?id=432817





------- Additional Comments From kevin at tummy.com  2008-02-15 19:03 EST -------

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
See below - Meets Packaging Guidelines.
See below - License
See below - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
57dd2731e05de80b04077e5e2396b1a8  greyhounds-0.8-pre-alpha.tar.bz2
57dd2731e05de80b04077e5e2396b1a8  greyhounds-0.8-pre-alpha.tar.bz2.1
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package is a GUI app and has a .desktop file

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have dist tag
OK - Should package latest version

Issues:

1. Not that it matters much, but upstream uses 'pre-alpha' instead of 'prealpha'

2. Can you ask upstream to clarify the license?
The README file has "The game is GPL-licensed."
None of the source files contain any licensing information.
That would seem to imply "GPL+" (ie, any version of the GPL).

3. Oddly, the Source0 url should probibly be:
http://downloads.sourceforge.net/byghound/%{name}-%{version}-pre-alpha.tar.bz2


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.