[Bug 432259] Review Request: speech-dispatcher - Required for speech synthesis on OLPC XO

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: speech-dispatcher - Required for speech synthesis on OLPC XO


https://bugzilla.redhat.com/show_bug.cgi?id=432259





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-02-16 11:32 EST -------
Well, for 0.6.6-2:

* Please don't introduce Epoch.
* Please don't use _unpackaged_files_terminate_build but explicitly
  remove files unneededly installed. Using _unpackaged_files_terminate_build
  frequently makes a package unusable when version is upgraded and some
  new files gets actually needed to be installed.
* Remove all unneeded comments to make your spec file easier to read.
* %{_libdir}/lib*.so should be in -devel subpackage
  (What I commented was about %{_libdir}/speech-dispatcher/lib*.so)
* What I meant by "dependency between subpackage must be EVR specific"
  is that for example -devel package should have
  "Requires: %{name} = %{version}-%{release}", not
  "Requires: %{name} = %{version}".
* %dir %{_libdir}/speech-dispatcher-modules is listed twice
* -doc subpackage must have Requires(post): /sbin/install-info or so
  And 
if [ $1 = 0 ]; then
    /sbin/install-info --delete %{_infodir}/%{name}.info %{_infodir}/dir || :
fi
  or so must be %preun, not %postun (please check the section
  "Texinfo" of
  http://fedoraproject.org/wiki/Packaging/ScriptletSnippets )
* %configure \
     --prefix=$RPM_BUILD_ROOT/%{_prefix} 
  - I guess you must not do this. This will sometimes override header
    files, configuration files etc  and leads to some undesirable
    results.

* And I am waiting for your submit of dotconf review request :)


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.