[Bug 433228] Review Request: distcc - Distributed C/C++ compilation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: distcc - Distributed C/C++ compilation


https://bugzilla.redhat.com/show_bug.cgi?id=433228





------- Additional Comments From ed at eh3.com  2008-02-17 17:16 EST -------
Here's a quick and not-yet-complete review:

 - ok : follows naming guidelines
 - ok : source matches upstream:

   88e4c15826bdbc5a3de0f7c1bcb429e558c6976d  distcc-2.18.3.tar.bz2
   88e4c15826bdbc5a3de0f7c1bcb429e558c6976d  distcc-2.18.3.tar.bz2.1

 - ok : license (GPLv2+) appears to be correct
 - ok : license appears in source and included in %doc
 - ok : spec file looks sane/legible
 - ok : built using "mock -r fedora-8-x86_64 distcc-2.18.3-1.fc8.src.rpm"
 - rpmlint reports:

   distcc.x86_64: W: file-not-utf8 /usr/share/doc/distcc-2.18.3/NEWS
   distcc-server.x86_64: W: incoherent-subsys /etc/init.d/distccd $prog
   distcc-server.x86_64: W: incoherent-subsys /etc/init.d/distccd $prog
   distcc-server.x86_64: W: incoherent-subsys /etc/init.d/distccd $prog
   distcc-server.x86_64: W: incoherent-init-script-name distccd

   where the file-not-utf8 warning can be ignored and the four other 
   warnings appear to be due to the package name being "distcc-server"
   (and not distcc or distccd) which means they are also harmless

 - ok : no need for ldconfig and no *.la files
 - ok : dir ownership looks good
 - ok : no need for -devel
 - ok : use of %clean and "rm -rf $RPM_BUILD_ROOT" at start of %install

Nits:
 - perhaps use Source0:
     http://distcc.samba.org/ftp/distcc/distcc-%{version}.tar.bz2
   which seems to be the prefered link from the web site

Next, I'll install it on a few machines and give it a try.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.