[Bug 433161] Review Request: cwdaemon - Morse daemon for the parallel or serial port

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cwdaemon - Morse daemon for the parallel or serial port


https://bugzilla.redhat.com/show_bug.cgi?id=433161


tmz at pobox.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |tmz at pobox.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From tmz at pobox.com  2008-02-17 22:30 EST -------
Hi Bob,

I have a few quick questions and minor suggested changes while I do a more
detailed review.

/usr/sbin should be replaced with %{_sbindir} in the file list

Adding a space between the changelog entries helps things like "make clog" work
better and makes the changelog easier to read.

Why is the devel package needed?  What is the purpose of the cwtest.c file?
(This might be irrelevant if a devel package isn't really needed, but why does
the devel package Require pkgconfig, it does not ship a .pc file?)

The README section on testing says to run test/cwtest.sh, but this location
won't exist for users of the rpm.  Is the test really needed?  If so, the
package would need to depend on nc (netcat) for it to work.  And the README
should probably be changed to refer to the location that the test script is
installed.  (Unless the test is really needed, I'd be inclined to not package
it.)

The manpage says to see @prefix@/share/cwdaemon/README for a description of the
circuitry, usage and testing of cwdaemon.  But this file isn't installed (it's
removed in the spec file).  Perhaps a symlink should be created?  Something
like:

    ln -sv %{docdir}/%{name}-%{version}/README %{_datadir}/%{name}/README

should create the link.  Then include it in the file list.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.