[Bug 433161] Review Request: cwdaemon - Morse daemon for the parallel or serial port

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cwdaemon - Morse daemon for the parallel or serial port


https://bugzilla.redhat.com/show_bug.cgi?id=433161





------- Additional Comments From tmz at pobox.com  2008-02-18 16:10 EST -------
(In reply to comment #7)
> qle is a package that Requires cwdaemon we have a srpm and spec started at
> http://bjensen.fedorapeople.org/pkgs/hams/#qle

The qle docs suggest that cwdaemon should be running as a daemon.  qle doesn't
start it for you.  The Debian cwdaemon packages setup a service in /etc/init.d.  

There is a draft guide for creating LSB compliant init scripts at:
http://fedoraproject.org/wiki/PackagingDrafts/SysVInitScript

I don't know if there are any other pages in the wiki with such examples or not.
 You can also look at many of the scripts in /etc/init.d to see how things are
done currently.

(In reply to comment #8)
> I do not know how to change the README file, I have asked my mentor for
> assistance.

The Debian package installs a README.Debian in %docdir, which tells the user a
little about how to start the service and use it in Debian.  It also points the
user to the README in %{_datadir}/%{name}.  That might be a reasonable way to go
here too.

Also worth noting is that the Debian maintainer is the upstream cwdaemon
maintainer.  So if you run into any general issues that should be fixed to make
the software more easily packaged, he may be amenable to making those changes
upstream -- assuming the changes are generic and not Fedora specific.

> In the mean time I updated SPEC and SRPM.

With the devel package removed, the %files section can be simplified a bit. 
There's no need to use separate globs for the files in %{_datadir}/%{name}. 
Instead of:

%dir %{_datadir}/%{name}/
%{_datadir}/%{name}/*.ps
%{_datadir}/%{name}/*.jpg
%{_datadir}/%{name}/*.sh
%{_datadir}/%{name}/*.png

You could just use:

%{_datadir}/%{name}

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.