[Bug 381241] Review Request: ncl - NCAR Command Language and NCAR Graphics

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ncl -  NCAR Command Language and NCAR Graphics


https://bugzilla.redhat.com/show_bug.cgi?id=381241


orion at cora.nwra.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?




------- Additional Comments From orion at cora.nwra.com  2008-02-18 17:00 EST -------
(In reply to comment #23)
> (In reply to comment #22)
> 
> > imake provides makedepend which is used.
> 
> Not a blocker, but a comment would be nice.

Done.
  
> > Not sure I understand about Site.local.  Seems fine the way it is.
> 
> My point is that Site.local is not really specific of ncl, one
> could imagine that a file with the same name is in another package.
> Disambiguating the same in SOURCES may be useful in settings where
> the same SOURCES directory is used for all packages.
> 
> As I said, only a suggestion.

Ah, I always forget about shared SOURCES directories.  Changed.

http://www.cora.nwra.com/~orion/fedora/ncl-5.0.0-9.fc8.src.rpm
http://www.cora.nwra.com/~orion/fedora/ncl.spec

* Mon Feb 18 2008 - Orion Poplawski <orion at cora.nwra.com> - 5.0.0-9
- Rename Site.local to Site.local.ncl
- Add comment for imake BR

Thanks again Patrice for your work.

Anyone else out there willing to approve a package as it is (with having to
register to download source)?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.