[Bug 432228] Review Request: nettle - A low-level cryptographic library
bugzilla at redhat.com
bugzilla at redhat.com
Tue Feb 19 04:51:32 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: nettle - A low-level cryptographic library
https://bugzilla.redhat.com/show_bug.cgi?id=432228
tibbs at math.uh.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
------- Additional Comments From tibbs at math.uh.edu 2008-02-18 23:51 EST -------
OK, the license is OK and the test suites are called:
All 39 tests passed
All 3 tests passed
There's only one remaining issue that I can see. The -devel package now
contains a static library, which is OK because this package doesn't build any
dynamic libraries. However, in this case, you also need to have the -devel
package provide nettle-static so that packages which will link against it can
require the -static package and thus be easily tracked. Please see the
"Packaging Static Libraries" section of
http://fedoraproject.org/wiki/Packaging/Guidelines
Since that's really just one line you need to add, I'll go ahead and approve
this and you can fix it when you check in.
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the Fedora-package-review
mailing list