[Bug 235249] Review Request: vdrift-data - VDrift data set

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: vdrift-data - VDrift data set


https://bugzilla.redhat.com/show_bug.cgi?id=235249


j.w.r.degoede at hhs.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |j.w.r.degoede at hhs.nl
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




------- Additional Comments From j.w.r.degoede at hhs.nl  2008-02-19 07:44 EST -------
Full review done:

MUST FIX
--------
* Make Source0 an url (default sf.net download url please)
* Change license to GPL+

Should FIX
----------
* Don't use mv in %install instead use "cp -a", mv destroys your builddir,
  making short-circuit builds fail, not that I know why anyone would want to do
  a short-circuit build in this case.

I trust you to fix the 2 trivial must fix items before import, so: APPROVED!


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.