[Bug 433443] Review Request: emacs-common-tuareg - Emacs mode for editing ocaml

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: emacs-common-tuareg - Emacs mode for editing ocaml


https://bugzilla.redhat.com/show_bug.cgi?id=433443


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2008-02-19 13:26 EST -------
Builds OK for me; I suggest you ping the xemacs maintainer to get some
assistance with the xemacs bits.

Why do you redefine %debug_package?  This is a noarch package and so doesn't
have a debug package in any case.

I really don't see the point in having a separate doc directory with the same
COPYING file in every subpackage; it really isn't necessary.  So far we're not
blocking on it, but I have to say I really don't understand why you would do that.

Currently all of the xemacs stuff is cruft since it's not being built, but I see
no problem in leaving it there in the hope that it can be made to work. 
However, if it's not ever going to be built then you get to drop the -common
package (and really the package should then be called just "emacs-tuareg").

You might want to consider dropping something into emacs-startdir so that this
package will work without additional configuration.  I think you can just put
append-tuareg.el there, although I don't know quite enough about emacs to say
that with certainty.

The only thing I see that needs changing is the debug_package thing, which is
really minor so I'll go ahead and approve this and you can remove it when you
check in.

* source files match upstream:
   2f22834259a6b0c065a6528a519eda3d0164a9bf2de8a5f7c041d6a91777261b  
   tuareg-mode-1.45.6.tar.bz2
* package meets naming and versioning guidelines.
* package conforms to emacs packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
  emacs-common-tuareg-1.45.6-1.fc9.noarch.rpm
   emacs-common-tuareg = 1.45.6-1.fc9
  =

  emacs-tuareg-1.45.6-1.fc9.noarch.rpm
   emacs-tuareg = 1.45.6-1.fc9
  =
   emacs(bin) >= 22.1.50
   emacs-common-tuareg = 1.45.6-1.fc9

  emacs-tuareg-el-1.45.6-1.fc9.noarch.rpm
   emacs-tuareg-el = 1.45.6-1.fc9
  =
   emacs-tuareg = 1.45.6-1.fc9

* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED, just remove the debug_package define when you check in.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.