[Bug 433477] Review Request: guake - Drop-down terminal for GNOME

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: guake - Drop-down terminal for GNOME


https://bugzilla.redhat.com/show_bug.cgi?id=433477





------- Additional Comments From guidolinfrancesco at email.it  2008-02-20 10:46 EST -------
Ok, there are some other things:

[-] The recommended value for the BuildRoot tag is:
BuildRoot:  %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 
http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473


[-] Packages should not use the PreReq tag.
http://fedoraproject.org/wiki/Packaging/Guidelines#head-c81b037a3a0d08f98eb9cb50594f5de73d1e461d


[-] *.la file should be removed. Add:
find %{buildroot} -name \*\.la -delete

after make install and remove those file from the file list.

http://fedoraproject.org/wiki/Packaging/Guidelines#head-2302ec1e1f44202c9cc4bcce24cb711266557ad7



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.