[Bug 283951] Review Request: log4net - A .NET framework for logging

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: log4net - A .NET framework for logging


https://bugzilla.redhat.com/show_bug.cgi?id=283951


dan at danny.cz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |dan at danny.cz
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




------- Additional Comments From dan at danny.cz  2008-02-21 04:23 EST -------
Don't forget to increase %Release tag (and also update changelog entry) for each
spec file public update. This iteration should be 1.2.10-2.

Formal review is here:
OK	source files match upstream:
	    4f8ff9892665469f915855692c9fc02801038837  incubating-log4net-1.2.10.zip
OK	package meets naming and versioning guidelines.
OK	specfile is properly named, is cleanly written and uses macros consistently.
OK	dist tag is present.
OK	build root is correct.
OK	license field matches the actual license.
OK	license is open source-compatible (ASL 2.0). License text included in package.
OK	latest version is being packaged.
OK	BuildRequires are proper.
N/A	compiler flags are appropriate (Mono app).
OK	%clean is present.
OK	package builds in mock (x86_64 Rawhide).
N/A	debuginfo package looks complete (no debuginfo - Mono app).
OK	rpmlint is silent.

log4net.x86_64: E: no-binary
The package should be of the noarch architecture because it doesn't contain
any binaries.

OK for Mono app

log4net.x86_64: E: only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.

OK for Mono app

OK	final provides and requires look sane.
OK	no shared libraries are added to the regular linker search paths.
OK	owns the directories it creates.
OK	doesn't own any directories it shouldn't.
OK	no duplicates in %files.
OK	file permissions are appropriate.
OK	no scriptlets present.
OK	code, not content.
OK	documentation is small, so no -docs subpackage is necessary.
OK	%docs are not necessary for the proper functioning of the package.
OK	no headers.
OK	has pkgconfig files in -devel subpackage.
OK	no libtool .la droppings.
OK	not a GUI app.

This package is APPROVED with the release updated to 2 (see above).

Because of the ExcludeArch you should also create a bug to track this issue and
make it block FE-ExcludeArch-ppc64=238953, see e.g. #309191.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.