[Bug 199154] Review Request: Slony-1 (postgresql-slony-engine)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Slony-1 (postgresql-slony-engine)


https://bugzilla.redhat.com/show_bug.cgi?id=199154





------- Additional Comments From ruben at rubenkerkhof.com  2008-02-21 14:22 EST -------
I see only two rpmlint. errors, quite easy to fix:

[ruben at localhost ~]$ rpmlint -i
rpmbuild/RPMS/i386/postgresql-slony1-1.2.13-1.fc9.i386.rpm 
postgresql-slony1.i386: E: non-standard-dir-perm
/usr/share/doc/postgresql-slony1-1.2.13 0644
A standard directory should have permission set to 0755. If you get this
message, it means that you have wrong directory permissions in some dirs
included in your package.

[ruben at localhost ~]$ rpmlint -i
rpmbuild/SRPMS/postgresql-slony1-1.2.13-1.fc9.src.rpm 
postgresql-slony1.src:229: W: macro-in-%changelog docs
Macros are expanded in %changelog too, which can in unfortunate cases lead
to the package not building at all, or other subtle unexpected conditions that
affect the build.  Even when that doesn't happen, the expansion results in
possibly "rewriting history" on subsequent package revisions and generally
odd entries eg. in source rpms, which is rarely wanted.  Avoid use of macros
in %changelog altogether, or use two '%'s to escape them, like '%%foo'.


Could you please go through the spec file and the comments in this review and
see if they still apply? For instance the specific fixes for 1.2.10?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.