[Bug 433135] Review Request: anyRemote - Bluetooth remote control

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: anyRemote - Bluetooth remote control


https://bugzilla.redhat.com/show_bug.cgi?id=433135


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-02-24 10:36 EST -------
Well,

* Why do you want to split -data, -doc subpackages although
  anyremote requires those subpackages? 
* Please remove Redundant Requires/BuildRequires
  - Why do you want to write the following Requires?
    coreutils
    binutils (is binutils really needed?)
    bash
    gawk
    bc (is bc really needed?)
    uucp (is uucp really needed?)
  - Requires: bluez-libs should be removed. These library
    dependency should be automatically added to binary rpms
    by rpmbuild.
* Also please remove redundant BuildRequires.
  - gcc
  - glibc-headers
  - make
  (please check "Exceptions" of
   http://fedoraproject.org/wiki/Packaging/Guidelines )
* On the other hands, at least some BuildRequries are missing.
  http://koji.fedoraproject.org/koji/taskinfo?taskID=466056
* Please consider to use %configure (check what %configure does
  by $ rpm --eval %configure)
* Stripping the rebuilt binaries by yourself is forbidden to create
  -debuginfo rpm correctly
* For man files, please use %{_mandir}/
* Please make it sure that all directories created when installing
  a rpm are owned by the rpm.
  For example, the directory %{_datadir}/%{name} is not owned
  by any package.
* Document files should usually be installed under
  %{_defaultdocdir}/%{name}-%{version}, not %{_datadir}/%{name}.
* To make it sure that all installed files are correctly built from
  open source files, we do not allow to install pre-compiled files
  (like .jar files) directly.
  So
  - If .jar files are needed, please rebuild it from sources.
  - Otherwise please don't install .jar files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.