[Bug 433642] Review Request: gnuradio - Software defined radio framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnuradio - Software defined radio framework


https://bugzilla.redhat.com/show_bug.cgi?id=433642





------- Additional Comments From lkundrak at redhat.com  2008-02-27 13:27 EST -------
Created an attachment (id=296101)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=296101&action=view)
gnuradio-3.1.1-1.fc8 rpmlint

Marek, Marek.

1.) Seems like you are missing the following:

BuildRequires:	boost-devel
BuildRequires:	python-devel
BuildRequires:	swig
BuildRequires:	doxygen

2.) This won't get packaged on 64bits, as your python modules are architecture
dependent:

Please replace python_sitelib definition with

%{!?python_sitearch: %define python_sitearch %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print get_python_lib(1)")}

and its occurences with python_sitearch

3.) gnuradio-usrp sumpackage is really empty. Should it be?

4.) RPMLint doesn't like you, see the attachment.

These definitely have to be addressed:
gnuradio.x86_64: W: non-executable-in-bin ...
gnuradio.x86_64: W: devel-file-in-non-devel-package ...

5.) You install libtool files which you should have %excluded:

For example
/usr/lib64/python2.5/site-packages/gnuradio/*.la

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.