[Bug 433547] Review Request: nagios-nsca - nagios passive check daemon

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nagios-nsca - nagios passive check daemon


https://bugzilla.redhat.com/show_bug.cgi?id=433547





------- Additional Comments From xavier at bachelot.org  2008-02-28 12:42 EST -------
Hi Wart,

Here are my preliminary comments on your package :

Summary is not capitalized.

I like nsca-client much better than what I used. Is it really useful to suffix
the packages with nagios- though ? This would clear rpmlint output from 
nagios-nsca.i386: W: incoherent-subsys /etc/rc.d/init.d/nsca $prog
nagios-nsca.i386: W: incoherent-init-script-name nsca

nagios, nrpe and all are in the group Applications/System. You probably want to
use the same.

I don't have the BR: on libmcrypt-devel and my package build fine. Is it
necessary to keep it ?

I have some requires on /sbin/service and /sbin/chkconfig, taken from nrpe
packages, not sure this is needed, can't find anything in the packaging guidelines.
Requires(preun): /sbin/service, /sbin/chkconfig
Requires(post): /sbin/chkconfig, /sbin/service
Requires(postun): /sbin/service

NetSaint can probably be stripped out of the description.

Upstream ships an initscript (generated at build time actually) that only lacks
reload, it might not worth to replace it completely.

0600 on the conf files is good.

No doc in nsca-client, add %doc Changelog LEGAL README SECURITY

Nothing more for today, let me know what you think.

Regards,
Xavier

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.