[Bug 429535] Review Request: perl-File-Tempdir - This module provide an object interface to tempdir() from File::Temp.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-File-Tempdir - This module provide an object interface to tempdir() from File::Temp.
Alias: perl-File-Tempdir

https://bugzilla.redhat.com/show_bug.cgi?id=429535





------- Additional Comments From rjones at redhat.com  2008-02-28 14:27 EST -------
+ rpmlint is clean on all packages
+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
- package doesn't satisfy packaging guidelines
  Needs to filter requires and provides, see:
  http://fedoraproject.org/wiki/Packaging/Perl
+ license meets guidelines and is acceptable to Fedora
+ license matches the actual package license
+ %doc includes license
  no separate license file so N/A
+ spec file written in American English
+ spec file is legible
+ upstream sources match sources in the srpm
  md5sum is 51f609343908803bbc78774ceb81c431
+ package successfully builds on at least one architecture
  i386
+ ExcludeArch bugs filed
  no ExcludeArch so N/A
+ BuildRequires list all build dependencies
+ %find_lang instead of %{_datadir}/locale/*
  N/A
+ binary RPM with shared library files must call ldconfig in %post and %postun
  N/A
+ does not use Prefix: /usr
+ package owns all directories it creates
  my reading of directory ownership for Perl indicates that the package
  is doing the right thing
+ no duplicate files in %files
+ %defattr line
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ consistent use of macros
+ package must contain code or permissible content
+ large documentation files should go in -doc subpackage
  documentation isn't large
+ files marked %doc should not affect package
+ header files should be in -devel
  N/A
+ static libraries should be in -static
  N/A
+ packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
  N/A
+ libfoo.so must go in -devel
  N/A
+ -devel must require the fully versioned base
  N/A
+ packages should not contain libtool .la files
  N/A
+ packages containing GUI apps must include %{name}.desktop file
  N/A
+ packages must not own files or directories owned by other packages
  (see above)
+ %install must start with rm -rf %{buildroot} etc.
+ filenames must be valid UTF-8

Optional:

+ if there is no license file, packager should query upstream
  ==> packager needs to talk to upstream
+ translations of description and summary for non-English languages, if available
? reviewer should build the package in mock
? the package should build into binary RPMs on all supported architectures
? review should test the package functions as described
+ scriptlets should be sane
+ pkgconfig files should go in -devel
+ shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin

----------

Please look at the Perl packaging guidelines to see if
the above problem needs to be corrected.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.