[Bug 435231] Review Request: xlog - Logging program for Ham Radio Operators

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xlog - Logging program for Ham Radio Operators


https://bugzilla.redhat.com/show_bug.cgi?id=435231


kanarip at kanarip.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |kanarip at kanarip.com
             Status|NEW                         |NEEDINFO
               Flag|                            |needinfo?(bob at fedoraunity.or
                   |                            |g)




------- Additional Comments From kanarip at kanarip.com  2008-02-28 18:52 EST -------
RPM Lint: OK
Package name: OK
Spec file: OK
License: OK
Actual License: OK
%doc License: OK
Spec file language: OK
Spec file readable: OK
Upstream source vs. used tarball: OK (md5sum)
Compile and Build:
 - F-7: FAILED (but not a target)
 - F-8: OK
 - rawhide: OK
 - EL-5: FAILED (but not a target)

Applicable Package Guidelines:
 - -debuginfo package: OK (~444k)
Locales: OK
Shared libs: N/A
Relocatable: N/A
Directory and file ownership: OK
No duplicate files in %files: See suggestions
File Permissions: OK
Macro usage: See suggestions
Code vs. Content: OK
(Large) Documentation: OK
%doc affecting runtime: OK
Header files in -devel package: N/A
Static Libraries in -static package: N/A
pkgconfig Requires: OK
Library files: N/A
Devel requires base package: N/A
.la libtool archives: N/A
Duplicate ownership of files/directories: OK
Remove BuildRoot: OK
UTF-8 filenames: OK

in %prep, invoke sed using the %{_sed} macro. Consider using '-i -e' for inline
regexp replacement (instead of moving the file around). Better yet, create and
apply a patch here.

AUTHORS file is in both %doc and %{_datadir}/xlog/, same goes for BUGS and
ChangeLog. I guess the files in %{_datadir}/xlog should go into %docs as well.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.