[Bug 435303] Review Request: perl-File-LibMagic - perl interface to LibMagic

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-File-LibMagic - perl interface to LibMagic


https://bugzilla.redhat.com/show_bug.cgi?id=435303





------- Additional Comments From rjones at redhat.com  2008-02-29 06:02 EST -------
OK there are a few basic problems you need to fix.

Add BuildRequires: file-devel

The tests fail in a very strange way for me:

t/1....................ok                                                    
t/2-easy...............ok                                                    
        1/6 unexpectedly succeeded
t/3-complete-errors....ok                                                    
        1/8 unexpectedly succeeded
t/3-complete...........ok                                                    
t/4-all................ok                                                    
t/6-oo.................ok 1/20                                               
#   Failed test 'MIME t/samples/foo.c'
#   in t/6-oo.t at line 27.
#          got: 'text/x-c charset=us-ascii'
#     expected: 'text/x-c; charset=us-ascii'
t/6-oo.................NOK 2                                                 
#   Failed test 'MIME data t/samples/foo.c'
#   in t/6-oo.t at line 36.
#          got: 'text/x-c charset=us-ascii'
#     expected: 'text/x-c; charset=us-ascii'
t/6-oo.................NOK 4                                                 
#   Failed test 'MIME t/samples/foo.foo'
#   in t/6-oo.t at line 27.
#          got: 'text/plain charset=us-ascii'
#     expected: 'text/plain; charset=us-ascii'
t/6-oo.................NOK 6                                                 
#   Failed test 'MIME data t/samples/foo.foo'
#   in t/6-oo.t at line 36.
#          got: 'text/plain charset=us-ascii'
#     expected: 'text/plain; charset=us-ascii'
t/6-oo.................NOK 8                                                 
#   Failed test 'MIME t/samples/foo.c'
#   in t/6-oo.t at line 48.
#          got: 'text/x-c charset=us-ascii'
#     expected: 'text/x-c; charset=us-ascii'
t/6-oo.................NOK 11                                                
#   Failed test 'MIME data t/samples/foo.c'
#   in t/6-oo.t at line 57.
#          got: 'text/x-c charset=us-ascii'
#     expected: 'text/x-c; charset=us-ascii'
t/6-oo.................NOK 13# Looks like you failed 6 tests of 20.          
t/6-oo.................dubious                                               
        Test returned status 6 (wstat 1536, 0x600)
DIED. FAILED tests 2, 4, 6, 8, 11, 13
        Failed 6/20 tests, 70.00% okay
Failed Test Stat Wstat Total Fail  Failed  List of Failed
-------------------------------------------------------------------------------
t/6-oo.t       6  1536    20    6  30.00%  2 4 6 8 11 13
 (2 subtests UNEXPECTEDLY SUCCEEDED).

Please try building under Fedora Rawhide and fix the above errors.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.