[Bug 435433] Review Request: ocrad -- An Optical Character Recognition program

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocrad -- An Optical Character Recognition program


https://bugzilla.redhat.com/show_bug.cgi?id=435433


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From panemade at gmail.com  2008-02-29 06:12 EST -------
1)make command should be using parallel make
make %{?_smp_mflags}

2)your build section should be
%configure 
make CXXFLAGS="$RPM_OPT_FLAGS" %{?_smp_mflags}

3) make install should be called as
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"

4) %files section should look like
%defattr(-,root,root,-)
%doc AUTHORS COPYING ChangeLog NEWS README TODO
%{_bindir}/ocrad
%{_mandir}/man1/*
%{_infodir}/ocrad.info.gz

5) missing requires
Requires(post): /sbin/install-info
Requires(preun): /sbin/install-info


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.