[Bug 426733] Review Request: Mediatomb - UPnP AV Mediaserver for Linux

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Mediatomb - UPnP AV Mediaserver for Linux


https://bugzilla.redhat.com/show_bug.cgi?id=426733





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-01-01 22:37 EST -------
For 0.10.0-1

* Requires
  - Requires: id3lib, file, sqlite, js" are redundant.
    rpmbuild examines the dependencies of libraries and adds them
    to the rebuilt binary rpms automatically.
    For example, "rpm -q --requires mediatomb" contains libid3-3.8.so.3,
    which should pull id3lib automatically

  - And please verify if "mysql" itself is needed. If only "mysql-libs" is
    needed, "Requires: mysql" should be removed.

* Conditional BuildRequires
  - build.log says:
--------------------------------------------------------------
   327  CONFIGURATION SUMMARY ----
   328  
   329  sqlite3       : yes
   330  mysql         : yes
   331  libjs         : yes
   332  libmagic      : yes
   333  inotify       : yes
   334  libexif       : yes
   335  id3lib        : yes
   336  taglib        : disabled
   337  libextractor  : disabled
--------------------------------------------------------------
     Please explain why you don't want to support taglib or libextrator
     (both are already in Fedora repo)

* Timestamps
  - To keep timestamps on installed files, please use
---------------------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
---------------------------------------------------------------
    While sometimes this does not work, this method usually works for
    recent Makefiles.

  - When using "install" or "cp" commands, please use "-p" option
    to keep timestamps, for example:
----------------------------------------------------------------
install -p -D -m0755 scripts/mediatomb-service-fedora
%{buildroot}%{_initrddir}/mediatomb
----------------------------------------------------------------

* Unowned files/directories
  - $ cat -n /etc/rc.d/init.d/mediatomb returns:
----------------------------------------------------------------
    57      mkdir -p "/$MT_HOME/$MT_CFGDIR"
    58      chown nobody "/$MT_HOME/$MT_CFGDIR"
----------------------------------------------------------------
    So actually mediatomb service creates /etc/mediatomb/ directory
    with the owner nobody. However, this directory is not owned by
    any rpms:
----------------------------------------------------------------
$ LANG=C rpm -qf /etc/mediatomb/
file /etc/mediatomb is not owned by any package
----------------------------------------------------------------
    * /etc/mediatomb must be owned by mediatomb with owner nobody
    * Also, IMO all files under /etc/mediatomb must be owned by
      mediatomb (perhaps by using %ghost)
    * Usually service should use its unique user/group.
      You can refer to:
      http://fedoraproject.org/wiki/Packaging/UsersAndGroups

* scriptlets/Requires for services (post, preun, etc)
  - scriptlets/Requires for mediatomb service are wrong.

    Please check the section "Services" of
    http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
    Also, please check the section "Syntax" "Scriptlet Ordering" of
    the same wiki page.

* Documents
  - The file "INSTALL" is usually needed for people who want to
    install the software by themselves and is not needed when people
    installs it using rpm.

! Note:
  Please make it sure that you change the release number of spec file
  each time you modify your spec file.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.