[Bug 250970] Review Request: ivtv-firmware - Firmware for the PVR 250/350/150/500 model series

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ivtv-firmware - Firmware for the PVR 250/350/150/500 model series


https://bugzilla.redhat.com/show_bug.cgi?id=250970





------- Additional Comments From kwizart at gmail.com  2008-01-02 10:33 EST -------
Happy New Year Axel!

(In reply to comment #19)
> This addresses the following comment further up:
> > What is wrong in this package are directory ownership,
> > This must be fixed... (even if this is a minor thing)

I think you miss me, your package cannot own directories that are targeted to
the filesystem, that's why I think it is better to remove them. That way, the
package will be good for the next half decade (as i expect).
That been said, keeping compat location are fine for RHEL4 and RHEL5, (if this
make sense to have them, but i don't think so as your repository have 0.10.6 for
RHEL5 and 2.6.18 kernels)... But for the currently supported Fedora version
(since Fedora 7 and Rawhide), I don't see any reason for keeping them... since
we use kernel 2.6.22 and later...

About preventing timestamps, you are right so this is fine as it is...

What remain are:
- compat location problem.
- no Doc are provided (this is mandatory to have them when they are provided
within the package: license-oemihvisv.txt and license-end-user.txt - so probably
both are needed).
All others points raised in this review are acceptable...

So to avoid conflict with the compat location problem I will try to ask advices
from others reviewers as:
- I don't see any reason to keep them as this will be useful only for older
version of the ivtv kernel module that I expect not to build against current
Fedora kernels.
- Fedora version that still use hotplug can have an older ivtv-firmware version
(as such I can agree to have a build conditional to provide them with older
Fedora version but not with the currently supported Fedora - Or to have
different specs in cvs branches for RHEL4/5 and Fedora)
- No userland application (in Fedora or elsewhere) really needs theses compat
location in currently maintained Fedora versions.
- Theses compat locations produce ownership directory problems , as such
deprecated location must be cleaned from the package.

If you disagree with some of theses points, please explain why.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.