[Bug 426561] Review Request: geoqo - GeoCaching and General Waypoint Database

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: geoqo - GeoCaching and General Waypoint Database


https://bugzilla.redhat.com/show_bug.cgi?id=426561


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2008-01-04 00:23 EST -------
Review:
+ package builds in mock (rawhide i386).
- rpmlint is NOT silent for SRPM and for RPM.
==> License should be GPLv2+ or Artistic
+ source files match upstream.
b038cdb0a419eec3569c15743c1cfd0f  geoqo-0.96.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ make test gave
All tests successful.
Files=15, Tests=247,  4 wallclock secs ( 1.79 cusr +  0.37 csys =  2.16 CPU)
+ Package  geoqo-0.96-4.fc9 ->
  Provides: perl(GeoDB) = 0.96 perl(GeoDB::AutoGUI::Values)
perl(GeoDB::AutoGUI::Values::Distinct) = 0.96 perl(GeoDB::AutoGUI::Values::Sets)
= 0.96 perl(GeoDB::DB) perl(GeoDB::Display) = 0.96 perl(GeoDB::Display::Count) =
0.96 perl(GeoDB::Display::Dump) = 0.96 perl(GeoDB::Display::Firefox) = 0.96
perl(GeoDB::Display::Graph) = 0.96 perl(GeoDB::Display::Graph::Find) = 0.96
perl(GeoDB::Display::Graph::Placed) = 0.96 perl(GeoDB::Display::Gui::List) =
0.96 perl(GeoDB::Display::Gui::List::Plugin) = 0.96
perl(GeoDB::Display::Gui::List::Plugin::Attributes) = 0.96
perl(GeoDB::Display::Gui::List::Plugin::Rate) = 0.96
perl(GeoDB::Display::Gui::List::Plugin::Show) = 0.96
perl(GeoDB::Display::Gui::List::Plugin::Solve) = 0.96
perl(GeoDB::Display::Gui::List::Plugin::Tag) = 0.96
perl(GeoDB::Display::Gui::Show) = 0.96 perl(GeoDB::Display::Help) = 0.96
perl(GeoDB::Display::List) = 0.96 perl(GeoDB::Display::Sets) = 0.96
perl(GeoDB::Display::Show) = 0.96 perl(GeoDB::Display::Stats) = 0.96
perl(GeoDB::Display::Top10) = 0.96 perl(GeoDB::Everywhere::Mem) = 0.96
perl(GeoDB::Export) = 0.96 perl(GeoDB::Export::Density) perl(GeoDB::Export::Gpx)
= 0.96 perl(GeoDB::Export::Html) = 0.96 perl(GeoDB::Export::Kml) = 0.96
perl(GeoDB::Export::Loc) = 0.96 perl(GeoDB::Export::System) = 0.96
perl(GeoDB::Import) perl(GeoDB::Import::Average) = 0.96
perl(GeoDB::Import::Create) = 0.96 perl(GeoDB::Import::Gpx) = 0.96
perl(GeoDB::Import::Loc) = 0.96 perl(GeoDB::Import::Project) = 0.96
perl(GeoDB::Import::System) = 0.96 perl(GeoDB::Import::Wigle) = 0.96
perl(GeoDB::Import::Zip) = 0.96 perl(GeoDB::Modify) = 0.96
perl(GeoDB::Modify::Classify) = 0.96 perl(GeoDB::Modify::Delete) = 0.96
perl(GeoDB::Modify::Diff) = 0.96 perl(GeoDB::Modify::Distance) = 0.96
perl(GeoDB::Modify::Drop) = 0.96 perl(GeoDB::Modify::Dropexisting) = 0.96
perl(GeoDB::Modify::Gctodiff) = 0.96 perl(GeoDB::Modify::Limit) = 0.96
perl(GeoDB::Modify::Load) = 0.96 perl(GeoDB::Modify::Makepuzzle) = 0.96
perl(GeoDB::Modify::Only) = 0.96 perl(GeoDB::Modify::Rate) = 0.96
perl(GeoDB::Modify::Rewrite) = 0.96 perl(GeoDB::Modify::Setattr) = 0.96
perl(GeoDB::Modify::Solved) = 0.96 perl(GeoDB::Modify::Sortby) = 0.96
perl(GeoDB::Modify::Symbol) = 0.96 perl(GeoDB::Modify::Tag) = 0.96
perl(GeoDB::Modify::Track) = 0.96 perl(GeoDB::Modify::Translate) = 0.96
perl(GeoDB::Search) perl(GeoDB::Search::Any) = 0.96 perl(GeoDB::Search::Attr) =
0.96 perl(GeoDB::Search::Cache) = 0.96 perl(GeoDB::Search::Geodining) = 0.96
perl(GeoDB::Search::Ident) = 0.96 perl(GeoDB::Search::Log) = 0.96
perl(GeoDB::Search::Rating) = 0.96 perl(GeoDB::Search::Set) = 0.96
perl(GeoDB::Search::Tag) = 0.96 perl(GeoDB::Search::Track) = 0.96
perl(GeoDB::Search::Waymark) = 0.96 perl(GeoDB::Search::Waypoint) = 0.96
perl(GeoDB::Search::Wigle) = 0.96 perl(GeoDB::Set) = 0.96 perl(GeoDB::Utils) =
0.96 perl(GeoDB::Waypoint) = 0.96 perl(GeoDB::Waypoint::Geocache) = 0.96
perl(GeoDB::Waypoint::Geodining) = 0.96 perl(GeoDB::Waypoint::Waymark) = 0.96
perl(GeoDB::Waypoint::Wigle) = 0.96
  Requires: /usr/bin/perl perl(Chart::Lines) perl(Config) perl(Cwd) perl(DBI)
perl(Data::Dumper) perl(Date::Parse) perl(Exporter) perl(File::Spec) perl(GD)
perl(GeoDB) perl(GeoDB::AutoGUI::Values) perl(GeoDB::DB) perl(GeoDB::Display)
perl(GeoDB::Display::Graph) perl(GeoDB::Display::Gui::List::Plugin)
perl(GeoDB::Export) perl(GeoDB::Export::Density) perl(GeoDB::Import)
perl(GeoDB::Import::Gpx) perl(GeoDB::Modify) perl(GeoDB::Search)
perl(GeoDB::Set) perl(GeoDB::Utils) perl(GeoDB::Waypoint)
perl(GeoDB::Waypoint::Geocache) perl(GeoDB::Waypoint::Geodining)
perl(GeoDB::Waypoint::Waymark) perl(GeoDB::Waypoint::Wigle) perl(Gtk2)
perl(IO::File) perl(QWizard) perl(QWizard) perl(QWizard::API)
perl(Text::Balanced) perl(XML::Simple) perl(strict)

+ Not a GUI app.
APPROVED.


SHOULD:
   Change License to GPLv2+ or Artistic

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.