[Bug 427514] Review Request: libnova - Libnova is a general purpose astronomy & astrodynamics library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libnova - Libnova is a general purpose astronomy & astrodynamics library


https://bugzilla.redhat.com/show_bug.cgi?id=427514


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From panemade at gmail.com  2008-01-04 06:47 EST -------
1) Review guidelines suggests that 
- MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for
directory ownership and usability).
   and as -devel package does not provide any .pc you should drop that.
2) Under %files section of -devel change following line 
 %{_includedir}/libnova/*.h
 to
 %{_includedir}/libnova
  this will ensure that packages owns this directory also. Otherwise it will be
owning only %{_includedir}/libnova/*.h files

3)This package contains COPYING which is main file for any package so add it to
%doc for libnova and libnova-devel 
License tag should be here LGPLv2+

4) good to add examples/*.c to %doc of %files section of -devel 



  

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.