[Bug 427507] Review Request: hunspell-bn - Bengali hunspell dictionaries

bugzilla at redhat.com bugzilla at redhat.com
Sat Jan 5 20:23:44 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hunspell-bn - Bengali hunspell dictionaries


https://bugzilla.redhat.com/show_bug.cgi?id=427507





------- Additional Comments From tibbs at math.uh.edu  2008-01-05 15:23 EST -------
rpmlint has one complaint:
  hunspell-bn.noarch: W: incoherent-version-in-changelog 1.0-1 20050726-1.fc9
Your changelog says 1.0-1 while the version is a bit different.

Also, you should include the Copyright file as %doc.

* source files match upstream:
   ad4f2133f7696a1d545572ab6724f2cc946a526025c6aeb84b67fdb2dd7b1bd5  
   bn-demo.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper (none)
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
X rpmlint has a valid complaint.
* final provides and requires are sane:
   hunspell-bn = 20050726-1.fc9
  =
   hunspell
* %check is not present; no test suite upstream.  I don't know Bengali so I'm
  afraid I can't test this.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list