[Bug 427479] Review Request: perl-ParseLex - Perl lexical analyzer.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-ParseLex - Perl lexical analyzer.


https://bugzilla.redhat.com/show_bug.cgi?id=427479





------- Additional Comments From rc040203 at freenet.de  2008-01-06 23:18 EST -------
Please make yourself familiar with the Fedora Packaging Guidelines.
http://fedoraproject.org/wiki/Packaging/Guidelines

Needswork:

- Package is noarch
=> remove OPTIMIZE="$RPM_OPT_FLAGS" from main make call

- Remove the %doc from the mans in %files
mans are automatically %doc'ed by rpm

- This construct is unnecessarily complex:
%dir %{perl_vendorlib}/Parse
%{perl_vendorlib}/Parse/*.pm

%{perl_vendorlib}/Parse
would suffice

- The 
chmod -R u+w %{_builddir}/%{pkgname}-%{version}
in %prep is superfluous, remove it.

- The construct as being used in %clean is being frowned upon in fedora.
Use
%clean
rm -rf %{buildroot}
instead.

- Your %buildroot doesn't comply to the packaging guidelines.

- The %defines at the beginning of the spec are unused. Remove them.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.