[Bug 240497] Review Request: R-multtest 1.18.0 - Resampling-based multiple hypothesis testing library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: R-multtest 1.18.0 - Resampling-based multiple hypothesis testing library


https://bugzilla.redhat.com/show_bug.cgi?id=240497





------- Additional Comments From alexl at users.sourceforge.net  2008-01-07 02:50 EST -------
Full review:

 - Package meets naming and packaging guidelines
 - Spec file matches base package name.
 - Spec has consistant macro usage.
 - Meets Packaging Guidelines.
 x License
 - License field in spec matches
 x License file  is not included in package
 - Spec in American English
 - Spec is legible.
 - Sources match upstream md5sum:
2a09d139ef362f0675c99e2e6d5ebe30  multtest_1.18.0.tar.gz
 - Package does not need ExcludeArch
 x BuildRequires:
Should have R-devel, not just R for arch-specific R packages
 - Spec handles locales/find_lang (N/A)
 - Package is not relocatable 
 - Package has %defattr and permissions on files is good.
 - Package has a correct %clean section.
 - Package has correct buildroot
      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 - Package is code or permissible content.
 - Doc subpackage needed/used.
 - Packages %doc files don't affect runtime.

 - Headers/static libs in -devel subpackage.
 - Spec has needed ldconfig in post and postun
 - .pc files in -devel subpackage/requires pkgconfig
 - .so files in -devel subpackage.
 - -devel package Requires: %{name} = %{version}-%{release}
 - .la files are removed.
 - Package compiles and builds on at least one arch.
 - Package has no duplicate files in %files.
 - Package doesn't own any directories other packages own.
 - Package owns all the directories it creates.
 - rpmlint output (can be ignored according to
http://fedoraproject.org/wiki/Packaging/R):
R-multtest.i386: W: one-line-command-in-%post /usr/lib/rpm/R-make-search-index.sh
R-multtest.i386: W: one-line-command-in-%postun /usr/lib/rpm/R-make-search-index.sh
 - final provides and requires are sane:
 - Has dist tag

Issues:

1. Does not build OK on koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=330245

2. Does this package actually need R-Biobase at build-time?  i.e. does the
install script actually check for it, or does it just need it at install time

3. BR: R-devel

4. Might be good to include something about this being part of Bioconductor in
%summary

These two can be dealt with after import:

3. It isn't clear what version of LGPL is meant from
http://www.bioconductor.org/packages/2.1/bioc/html/multtest.html please ask
upstream to clarify
4. Ask upstream to include LGPL license in package and/or in source code itself.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.