[Bug 427514] Review Request: libnova - Libnova is a general purpose astronomy & astrodynamics library

bugzilla at redhat.com bugzilla at redhat.com
Mon Jan 7 10:42:29 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libnova - Libnova is a general purpose astronomy & astrodynamics library


https://bugzilla.redhat.com/show_bug.cgi?id=427514


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2008-01-07 05:42 EST -------
Review:
+ package builds in mock (rawhide i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
8f4c6860aa627c5d0694b8bb5699fe7f  libnova-0.12.1.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ BuildRequires are proper.
+ Compiler flags used correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no static libraries.
+ no .pc file present.
+ -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ ldconfig scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package libnova-0.12.1-1.fc9 ->
  Provides: libnova-0.12.so.1
  Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3)
libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libm.so.6
libm.so.6(GLIBC_2.0) libm.so.6(GLIBC_2.1) libnova-0.12.so.1 rtld(GNU_HASH)
+ Package libnova-devel-0.12.1-1.fc9 ->
  Requires: libnova = 0.12.1-1.fc9 libnova-0.12.so.1
+ Not a GUI App.
APPROVED.


I have sponsored you. Follow CVSAdminProcedure.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list