[Bug 427342] Review Request: jday - A simple command to convert calendar dates to julian dates

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: jday - A simple command to convert calendar dates to julian dates


https://bugzilla.redhat.com/show_bug.cgi?id=427342


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|177841                      |
              nThis|                            |
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2008-01-07 06:18 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for RPM But NOT for RPM.
jday.src: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 1)
==>cosmetic message. 
+ source files match upstream url
817af56005d1346677271ed2fab63ef5  jday-2.4.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ BuildRequires are proper.
+ Compiler flags used correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no static libraries.
+ jday.pc file present.
+ -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ ldconfig scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package jday-2.4-1.fc9 ->
  Provides: libjday.so.2
  Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3)
libc.so.6(GLIBC_2.3.4) libjday.so.2 rtld(GNU_HASH)
+ Package jday-devel-2.4-1.fc9 ->
  Requires: jday = 2.4-1.fc9 libjday.so.2
+ Not a GUI App.
APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.