[Bug 427674] Review Request: themonospot -application that can be used to scan an avi file and extract some informations about audio and video data flow

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: themonospot -application that can be used to scan an avi file and extract some informations about audio and video data flow


https://bugzilla.redhat.com/show_bug.cgi?id=427674





------- Additional Comments From hmandevteam at gmail.com  2008-01-07 10:00 EST -------
I writing new SPEC file with follow modify, if is ok for you i wait a comment to
this thread to upload new files, thanks.

CHANGED:
> GPL is no longer a valid license tag.
Changed to GPLv2

> Applications/AudioVideo is not one of the standard groups
Changed to Audiovideo;AudioVideoEditing

> your %descriptions lacks a subject for the phrase that is included in the
> first paragraph. I also suggest to use "Using themonospot it is also possible
> to modify FourCC informations <rest of phrase here>" for the second paragraph.
Inserted subject in the first paragraph and "Using Themonospot it is..." in second

> the %distribution and %vendor tags should not be included in your spec 
deleted %distribution and %vendor

> Please use rpm macros instead of absolute paths (i.e. replace "./configure
> --prefix=/usr" with  "%configure --prefix=%{_prefix}" or even better just with
> %configure )
changed with %configure

> the desktop file should be installed according to
>
http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755,
> not using ln;pixmaps should probably be included in %files
changed in [%post] section from ln to mv -f so the files will be moved in right
path.

> the .pc file should probably not be included
deleted .pc file from %files list

> the version reported by the most recent entry in the changelog is not
> identical to the one of the package (0.6.5 versus 0.6.5-1)
modified changelog version to 0.6.5-2 (as release number) and adjust date
(delete time in according to Packaging Guidelines)

> And last but not least, you should provide access to the src.rpm.
I will generate with ... rpmbuild -ba --sign themonospot-0.6.5.SPEC
so i will upload also src.rpm file

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.