[Bug 427738] Review Request: dropbear - SSH2 server and client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dropbear - SSH2 server and client


https://bugzilla.redhat.com/show_bug.cgi?id=427738





------- Additional Comments From tcallawa at redhat.com  2008-01-07 10:57 EST -------
Only problems that I see:

- Please put the full URL path to the Sources (where possible).

- dropbear.src: W: strange-permission dropbear.init 0755

Should be easy enough to fix, just make sure the perms are -x on that file
before making the SRPM.

- dropbear.x86_64: W: file-not-utf8 /usr/share/doc/dropbear-0.50/CHANGES

Just add these lines in %setup:

# convert to UTF-8
iconv -f iso-8859-1 -t utf-8 -o CHANGES{.utf8,}
mv CHANGES{.utf8,}

- dropbear.x86_64: W: service-default-enabled /etc/rc.d/init.d/dropbear
  dropbear.x86_64: W: no-reload-entry /etc/rc.d/init.d/dropbear

Do you intend for this service to be enabled by default? Also, since the init
file is custom, please add the reload function. It can be as simple as calling
"stop, start".

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.