[Bug 394751] Review Request: kmplayer - Video plugin for Konqueror and basic Gstreamer/Xine frontend

Mon Jan 7 20:42:18 UTC 2008

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kmplayer - Video plugin for Konqueror and basic Gstreamer/Xine frontend

https://bugzilla.redhat.com/show_bug.cgi?id=394751

wolfy at nobugconsulting.ro changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |wolfy at nobugconsulting.ro
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?

------- Additional Comments From wolfy at nobugconsulting.ro  2008-01-07 15:42 EST -------
Package Review
==============

Key:
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format %{name}.spec.
 [x] Package meets the Packaging Guidelines.
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: x86_64 local + all arch supported by koji scratch build
 [x] Rpmlint output:
source rpm:  E: unknown-key GPG#ff6382fa (ignorable)
binary rpm:
 kmplayer.x86_64: W: dangling-relative-symlink
/usr/share/doc/HTML/ru/kmplayer/common ../common
 kmplayer.x86_64: W: dangling-relative-symlink
/usr/share/doc/HTML/sv/kmplayer/common ../common
 kmplayer.x86_64: W: dangling-relative-symlink
/usr/share/doc/HTML/et/kmplayer/common ../common
 kmplayer.x86_64: W: dangling-relative-symlink
/usr/share/doc/HTML/it/kmplayer/common ../common
 kmplayer.x86_64: W: dangling-relative-symlink
/usr/share/doc/HTML/es/kmplayer/common ../common
 kmplayer.x86_64: W: dangling-relative-symlink
/usr/share/doc/HTML/fr/kmplayer/common ../common
 kmplayer.x86_64: W: dangling-relative-symlink
/usr/share/doc/HTML/en/kmplayer/common ../common
 kmplayer.x86_64: W: dangling-relative-symlink
/usr/share/doc/HTML/de/kmplayer/common ../common
 kmplayer.x86_64: W: dangling-relative-symlink
/usr/share/doc/HTML/pt/kmplayer/common ../common
 kmplayer.x86_64: W: dangling-relative-symlink
/usr/share/doc/HTML/da/kmplayer/common ../common
 kmplayer.x86_64: W: dangling-relative-symlink
/usr/share/doc/HTML/nl/kmplayer/common ../common
 kmplayer.x86_64: E: invalid-soname /usr/lib64/libkdeinit_kmplayer.so
libkdeinit_kmplayer.so
 kmplayer.x86_64: E: invalid-soname /usr/lib64/libkmplayercommon.so
libkmplayercommon.so
KDE specific, ignorable
 [x] Package is not relocatable.
 [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root)
 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [!] License field in the package spec file matches the actual license.
     License type:
        in %tag: GPLv2+
        source files' licenses: GPLv2+ and LGPLv2+
 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
     SHA1SUM of package: 52bfa017e1360fdc60c10445090c867039da4830
kmplayer-0.10.0c.tar.bz2
 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that are
listed in the exceptions section of Packaging Guidelines.
 [x] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [!] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===
 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on:devel/x86_64
 [x] Package should compile and build into binary rpms on all supported
architectures.
     Tested on: ppc/ppc64/x86/x86_64 (koji scratch build)
 [?] Package functions as described.
 [x] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [x] File based requires are sane.
=== Issues ===
1. The license tag and the licenses from the source files do not coincid. Some
of the licenses used by the source files are  GPLv2+ but others are LGPLv2+ (see
kmplayer_def.h, kmplayer_koffice_part*, viewarea.cpp, xineplayer.h and maybe
others ). Because of this I think that the correct license tag should be "
GPLv2+ and LGPLv2+". If I am wrong, please correct me.
2. The desktop file (kmplayer.desktop) has a small error. According to
http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755
the icon tag can be specified either as a full path to specific icon file or a
short name without file extension. You have used a short name WITH extension
3. Minor: there is a duplicate BR:cairo-devel (by gtk2-devel)

I'll trust you to fix these issues before uploading to CVS.

=== Final Notes ===
1. The package does contain .la files but they are needed for runtime (KDE
specific requirement).
2. I had not yet the opportunity to test the program and I cannot do it now. I
will do it in a couple of hours and come back with the final of the review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.