[Bug 191492] Review Request: unuran-0.7.2

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: unuran-0.7.2


https://bugzilla.redhat.com/show_bug.cgi?id=191492


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tibbs at math.uh.edu
OtherBugsDependingO|201449                      |
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2008-01-08 00:12 EST -------
This fails to build for me:

error: Installed (but unpackaged) file(s) found:
   /usr/share/info/dir

The usual way to deal with this is to remove $RPM_BUILD_ROOT/%{_infodir}/dir at
the end of %install.  install-info will properly manage the info catalog in your
scriptlets.

After doing that, I can build and check this; rpmlint has some complaints:
  unuran.src: W: mixed-use-of-spaces-and-tabs (spaces: line 25, tab: line 1)
Not a big deal; fix it if you like.

  unuran.x86_64: W: devel-file-in-non-devel-package 
   /usr/include/unuran_urng_prng.h
  unuran.x86_64: W: devel-file-in-non-devel-package 
   /usr/include/unuran_urng_rngstreams.h
  unuran.x86_64: W: devel-file-in-non-devel-package
   /usr/include/unuran.h
  unuran.x86_64: W: devel-file-in-non-devel-package 
   /usr/include/unuran_urng_gsl.h
These must go in a -devel package.

  unuran.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libunuran.so
The unversioned .so file must be in a -devel package.

The pdf documentation should probably be in the -devel package as well, since
it's not of much use at runtime and it's half the size of the package.

Fortunately the include files have sufficiently distinct names that they don't
need to be relocated to a subdirectory of %{_includedir}.

It really looks to me like the license is GPLv2+, not just GPLv2; running
  grep -r -B1 'any later version' .
in the unpacked source directory shows plenty of hits.

The scriptlets need a couple of tweaks.  First, you need to do install-info in
%preun, not %postun, and you need to conditionalize it for uninstalls only:

  %preun
  if [ $1 = 0 ]; then
    /sbin/install-info --delete %{_infodir}/unuran.info.gz %{_infodir}/dir || :
  fi

  %postun -p /sbin/ldconfig

And unfortunately rpm doesn't generate dependencies for multi-line scriptlets,
so you will need some dependencies:
  Requires(post): /sbin/ldconfig, /sbin/install-info
  Requires(preun): /sbin/install-info

Otherwise I think things look OK.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.