[Bug 191492] Review Request: unuran-0.7.2

bugzilla at redhat.com bugzilla at redhat.com
Tue Jan 8 12:51:19 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: unuran-0.7.2


https://bugzilla.redhat.com/show_bug.cgi?id=191492





------- Additional Comments From pertusus at free.fr  2008-01-08 07:51 EST -------
Also I would suggest passing INSTALL='install -p' or similar to
make install DESTDIR=$RPM_BUILD_ROOT
to keep header files timestamps, and I would also suggest dropping 
the .gz suffixes in the install-info scriptlets, install-info
should figure them out automatically.

What about the library unuran optionally depends on? (gsl, 
rngstream and prng). Is it useful to have them used 
during the build?

I also think that it could be nice to have 

%check
make check

Also maybe you could ship the examples directory.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list