[Bug 226054] Merge Review: libuser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libuser


https://bugzilla.redhat.com/show_bug.cgi?id=226054





------- Additional Comments From mitr at redhat.com  2008-01-08 08:00 EST -------
Thanks for the review!

(In reply to comment #5)
> This shows up when you run rpmlint on the installed package:
>   libuser.x86_64: W: unused-direct-shlib-dependency 
>    /usr/lib64/libuser.so.1.1.10 /lib64/libdl.so.2
> I don't think it's a big issue but perhaps you know what causes it.  It just
> looks like libuser.so is linked against libdl.so but doesn't actually call any
> symbols from it.
The -ldl is added by libgmodule's pkgconfig files.  I'm not happy about it but I
don't think this should be hacked around in libuser.
 
> I've seen the "WITH_SELINUX" stuff in other formerly core packages and I have
> to say I'm not quite sure what utility it has these days where everything is
> always built with selinux support.
Yes, it only encourages bug reports when !WITH_SELINUX breaks.  I'll remove it.

> I think the bit at the end of %install really should be in a %check section
> instead, but that's not the kind of change I want to commit without consulting
> you.
Probably, I'll try that.

> This file in the -devel package looks a bit odd:
>   /usr/include/libuser/default.-c
> Any idea if that's a typo?
That's not a typo.  I should really get rid of this file...


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.