[Bug 249548] Review Request: fedora-ds-admin - Administration server used by Fedora Directory Server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fedora-ds-admin - Administration server used by Fedora Directory Server


https://bugzilla.redhat.com/show_bug.cgi?id=249548





------- Additional Comments From dennis at ausil.us  2008-01-08 20:39 EST -------
fedora-ds-admin.src: W: strange-permission fedora-ds-admin-cvs.sh 0775
fedora-ds-admin.x86_64: E: 
script-without-shebang /usr/lib64/dirsrv/perl/ASDialogs.pm
fedora-ds-admin.x86_64: E: 
script-without-shebang /usr/lib64/dirsrv/perl/AdminUtil.pm
fedora-ds-admin.x86_64: E: 
script-without-shebang /usr/lib64/dirsrv/perl/ConfigDSDialogs.pm
fedora-ds-admin.x86_64: E: script-without-shebang /etc/sysconfig/dirsrv-admin
fedora-ds-admin.x86_64: E: 
script-without-shebang /usr/lib64/dirsrv/perl/RegDSDialogs.pm
fedora-ds-admin.x86_64: E: 
script-without-shebang /usr/lib64/dirsrv/perl/AdminServer.pm
fedora-ds-admin.x86_64: E: 
script-without-shebang /usr/lib64/dirsrv/perl/AdminMigration.pm
fedora-ds-admin.x86_64: E: subsys-not-used /etc/rc.d/init.d/dirsrv-admin
fedora-ds-admin.x86_64: W: incoherent-init-script-name dirsrv-admin



fix the file permissions on the perl modules and  /etc/sysconfig/dirsrv-admin 
they should be 644 not 755 
/etc/sysconfig/dirsrv-admin  should be marked as config noreplace 
fix the use of subsys in the initscript 

source matches upstream 
[dennis at bratac SPECS]$ sha1sum fedora-ds-admin-1.1.1.tar.bz2
b06576c65f7b649472229d2435a1275442f0d8ec  fedora-ds-admin-1.1.1.tar.bz2
[dennis at bratac SPECS]$ sha1sum ../SOURCES/fedora-ds-admin-1.1.1.tar.bz2
b06576c65f7b649472229d2435a1275442f0d8ec  ../SOURCES/fedora-ds-admin-1.1.1.tar.bz2


Then it will be in pretty good shape


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.