[Bug 428112] Review Request: perl-HTML-PrettyPrinter - Generate nice HTML files from HTML syntax trees

bugzilla at redhat.com bugzilla at redhat.com
Wed Jan 9 11:21:49 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-HTML-PrettyPrinter - Generate nice HTML files from HTML syntax trees


https://bugzilla.redhat.com/show_bug.cgi?id=428112





------- Additional Comments From xavier at bachelot.org  2008-01-09 06:21 EST -------
(In reply to comment #1)
> Just one small thing i saw that is:
> i would replace 
> %{__perl} Makefile.PL INSTALLDIRS=vendor
> with
> %{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
> 
This is a noarch package, so OPTIMIZE is not needed.

> I am also not sure if we need " || :" after check

You're right, it is not in the template, I'll remove it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list