[Bug 427273] Review Request: firstaidkit - System Rescue Tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: firstaidkit - System Rescue Tool


https://bugzilla.redhat.com/show_bug.cgi?id=427273


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2008-01-09 22:41 EST -------
Review:
+ package builds in mock (rawhide i386).
+ rpmlint is silent for SRPM. But not for RPM.
firstaidkit-devel.noarch: E: only-non-binary-in-usr-lib
==>this is ok here.
+ source files match upstream.
7a4e783e4c95d875cb8b15d2d119dfc6  firstaidkit-0.1.0.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ -devel and -plugins-all subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.

SHOULD:
  Add some lines of text in SPEC in comments on how to create tarball. Upstream
does not provide any direct download links.

I am approving this with assuming you will add above comment.

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.