[Bug 426103] Review Request: xorg-x11-drv-wiimote - Xorg input driver for the Wiimote

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xorg-x11-drv-wiimote - Xorg input driver for the Wiimote


https://bugzilla.redhat.com/show_bug.cgi?id=426103


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2008-01-11 00:15 EST -------
For some reason I couldn't convince mock to pull the fixed libwiimote package
from my local repo so I just took the lazy way out and waited until it hit rawhide.

Builds fine and rpmlint only says
 xorg-x11-drv-wiimote.src: W: mixed-use-of-spaces-and-tabs
  (spaces: line 3, tab: line 10)
which I don't particularly care about.

* source files match upstream:
   40237e4539af81ab9c18e967454bf72e797b30264541e79116220d120d7ed09a  
   xf86-input-wiimote-0.0.1.tar.bz2
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* debuginfo package looks complete.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
   wiimote_drv.so()(64bit)
   xorg-x11-drv-wiimote = 0.0.1-1.fc9
  =
   libcwiimote.so.0()(64bit)
   xorg-x11-server-Xorg

* %check is not present; I can't really test this, as I have the wiimote but not 
   the bluetooth.
* no shared libraries are added to the regular linker search paths.
* doesn't create or own any directories
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.