[Bug 427526] Review Request: librtfcomp - Library for reading of compressed RTF files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: librtfcomp -  Library for reading of compressed RTF files


https://bugzilla.redhat.com/show_bug.cgi?id=427526


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




------- Additional Comments From panemade at gmail.com  2008-01-11 04:14 EST -------
Review:
+ package builds in mock (rawhide i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
b7f70dc41687d920ec9f47c01f56d6ce  librtfcomp-1.1.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ BuildRequires are proper.
+ Compiler flags used correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no static libraries.
+ no .pc file present.
+ -devel,-python subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ ldconfig scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package librtfcomp-1.1-1.fc9 ->
  Provides: librtfcomp.so.0
  Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3)
libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) librtfcomp.so.0 rtld(GNU_HASH)
+ Package librtfcomp-devel-1.1-1.fc9 ->
  Requires: Pyrex librtfcomp = 1.1-1.fc9 librtfcomp.so.0 python-devel
+ Package librtfcomp-python-1.1-1.fc9 ->
  Provides: pyrtfcomp.so
+ Not a GUI App.
APPROVED.

SHOULD:
   License is LGPLv2+ from LICENSE file

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.