[Bug 428007] Package review: cronie

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Package review: cronie


https://bugzilla.redhat.com/show_bug.cgi?id=428007





------- Additional Comments From pertusus at free.fr  2008-01-11 08:03 EST -------
I like the name.

I have some comments on upstream.
* I think it would be better to isolate crond.pam, crond.sysconfig
  vixie-cron.init (renamed cronie.init) in something like a contrib
  directory and not install them, they are platform specific.
* you should not use AC_TRY_RUN, but AC_TRY_LINK (or similar) otherwise
  cross compilation is impossible.
* you should use sysconfdir instead of etcdir
* There are some strange unconditional AC_DEFINE.
* The following shouldn't be useful:
crond_LDFLAGS = \
        $(LDFLAGS)
* cp in man/Makefile.am are wrong. automake should be able to figure
  out what to do with these files, and if it cannot there are better
  way to handle them.
* The fact that vixie-cron.init and crond.sysconfig appear in the 
  distribution is complete magic to me
* You should copy the automake/autoconf files, not link them. Like
automake -c
or simply
autoreconf
* there are many things in src/pathnames.h that should be set from
  configure values.
* there is an url missing in the README

I can make patches for the things for which patches make sense.

Is there a version control somewhere for cronie?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.