[Bug 226429] Merge Review: sqlite

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: sqlite
Alias: sqlite

https://bugzilla.redhat.com/show_bug.cgi?id=226429





------- Additional Comments From rnorwood at redhat.com  2008-01-11 22:30 EST -------
Package review:

- rpmlint checks return:

    sqlite-3.5.4-2.fc9.src.rpm -

sqlite.src:14: W: unversioned-explicit-obsoletes sqlite3
sqlite.src:14: W: unversioned-explicit-obsoletes sqlite3-devel

sqlite3 last appeared (AFAICT) in FC-3's extras.  Since it's more than 3
releases old, we can drop this obsoletes.  Also, the matching 'provides' are
missing.

sqlite.src: W: mixed-use-of-spaces-and-tabs (spaces: line 57, tab: line 11)

Easy to fix.

  sqlite-devel-3.5.4-2.fc9.i386.rpm -

sqlite-devel.i386: W: summary-ended-with-dot Development tools for the sqlite3
embeddable SQL database engine.

* both of the above are fixed in the attached patch to the spec file. *

  sqlite-tcl-3.5.4-2.fc9.i386.rpm -

sqlite-tcl.i386: W: no-documentation

* Can probably be ignored

sqlite-tcl.i386: W: summary-ended-with-dot Tcl module for the sqlite3 embeddable
SQL database engine.

* fixed in attached patch

sqlite-tcl.i386: E: arch-dependent-file-in-usr-share
/usr/share/tcl8.5/sqlite3/libtclsqlite3.so
sqlite-tcl.i386: W: unstripped-binary-or-object
/usr/share/tcl8.5/sqlite3/libtclsqlite3.so

* This is obviously wrong, they should be in /usr/lib - I'm not sure what to do
to fix this properly, however.

- package meets naming guidelines - Ok
- license ( ) OK, text in %doc, matches source - Ok - Public Domain
- spec file legible, in am. english - Ok
- source matches upstream - Ok
- package compiles on devel (x86) - Ok
- no missing BR - Ok
- no unnecessary BR - Ok
- no locales - Ok
- not relocatable - Ok
- owns all directories that it creates - Ok
- no duplicate files - Ok
- permissions ok - Ok
- %clean - Ok
- macro use consistent - Ok
- code, not content - Ok
- no need for -docs - Ok
- nothing in %doc affects runtime - Ok
- no need for .desktop file - Ok
- devel package ok - Ok
- no .la files - removed in %install section
- post/postun ldconfig ok - Ok
- devel requires base package n-v-r - Ok


- Tests are not run by default.

* This is probably because several tests fail.  I've enabled tests in the
attached specfile patch, and included patches which fix or comment out the tests
that fail.  Someone needs to check to see why the failing tests are failing, and
either fix the tests upstream, fix the bug upstream, or figure out why the tests
fail for us.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.