[Bug 413321] Review Request: inotail - An inotify-enabled tail replacement

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: inotail - An inotify-enabled tail replacement
Alias: inotail

https://bugzilla.redhat.com/show_bug.cgi?id=413321


moritz at barsnick.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |moritz at barsnick.net




------- Additional Comments From moritz at barsnick.net  2008-01-14 04:01 EST -------
Can I re-open or append for improval? (If not, I'll file a new ticket.)

The SPEC file has such a line in the %install section:
chmod 0755 %{buildroot}/usr/bin/inotail

a) Permissions can (or should?) be forced in the %files section using %attr.
b) %{buildroot}/usr/bin must comply with the %files's %{_bindir}. One of the 
two is wrong. Assuming this tool has a very hand-crafted Makefile, and it is 
built using "prefix=%{buildroot}/usr", "/usr/bin" may (or may not) be the 
correct choice.

Thanks for the tool, by the way. :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.